Skip to content

Commit

Permalink
Merge pull request #1112
Browse files Browse the repository at this point in the history
v2.5.2
  • Loading branch information
antoinepirlot authored Dec 18, 2024
2 parents 771eb6f + 6c976e1 commit 3ecd326
Show file tree
Hide file tree
Showing 6 changed files with 40 additions and 20 deletions.
6 changes: 6 additions & 0 deletions RELEASES_EN.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@ Tu peux retrouver ce fichier en [français 🇫🇷](RELEASES_FR.md)

## 2.5 (Android 5.1.1 Lollipop and later)

### 2.5.2

Improvements, optimizations and troubleshooting:

* Hide start timer if the timer is running

### 2.5.1

Improvements, optimizations and troubleshooting:
Expand Down
6 changes: 6 additions & 0 deletions RELEASES_FR.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@ You can find this file in [english 🇬🇧](RELEASES_EN.md)

## 2.5 (Android 5.1.1 Lollipop et ultérieur)

### 2.5.2

Améliorations, optimisations et dépannage:

* Le bouton démarrer le minuteur est masqué lorsque le minuteur fonctionne

### 2.5.1

Améliorations, optimisations et dépannage:
Expand Down
4 changes: 2 additions & 2 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ android {
applicationId = nameSpace
minSdk = 22
targetSdk = 34
versionCode = 66
versionName = "2.5.1"
versionCode = 67
versionName = "2.5.2"

testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
vectorDrawables {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,25 +160,27 @@ internal fun CreateTimerForm(
}

Spacer(modifier = Modifier.size(5.dp))
}
Button(
onClick = {
computeTime(
secondsIntField = secondsIntField,
minutesIntField = minutesIntField,
hoursIntField = hoursIntField
)
playbackViewModel.setTimer(
scope = scope,
snackBarHostState = snackBarHostState,
hours = hoursIntField.intValue,
minutes = minutesIntField.intValue,
seconds = secondsIntField.intValue
)
onFinished?.invoke()
} else {
Button(
onClick = {
computeTime(
secondsIntField = secondsIntField,
minutesIntField = minutesIntField,
hoursIntField = hoursIntField
)
playbackViewModel.setTimer(
scope = scope,
snackBarHostState = snackBarHostState,
hours = hoursIntField.intValue,
minutes = minutesIntField.intValue,
seconds = secondsIntField.intValue
)
onFinished?.invoke()
}
) {

NormalText(text = stringResource(R.string.start_timer_button_content))
}
) {
NormalText(text = stringResource(R.string.start_timer_button_content))
}
}
}
Expand Down
3 changes: 3 additions & 0 deletions fastlane/metadata/android/en-US/changelogs/67.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Improvements, optimizations and troubleshooting:

* Hide start timer if the timer is running
3 changes: 3 additions & 0 deletions fastlane/metadata/android/fr-FR/changelogs/67.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Améliorations, optimisations et dépannage:

* Le bouton démarrer le minuteur est masqué lorsque le minuteur fonctionne

0 comments on commit 3ecd326

Please sign in to comment.