Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Cpp: Remove deprecated policy settings
Setting any policy to the OLD behavior is almost always a bad idea in the long run as the OLD behavior of cmake policies are deprecated by definition and may be completely removed in a future cmake version. The changes in cmake behavior introduced by this are - Only auto-expand variables in if-expressions, if they are unquoted. Doing this differently just opens you up for hell to break loose. As far as I can tell, we don't make use of this behavior anyway. - If referring to a non-existing target with get_target_properties, cmake will now produce an error. This is what one usually wants as referencing non-existing targets is simply a bug in your setup. - cmake won't recognize "DEFINITIONS" as a built-in directory property. Instead, one has to use the (proper) "COMPILE_DEFINITIONS". Again, I was unable to find a location in which we use "DEFINITIONS", so the change should have no effect on us. - "@rpath" can now be used in a target's install name on macOS. With the OLD behavior, this had to explicitly be enabled, while the new behavior is to enable this by default. In order to still remain at the old behavior, without depending on deprecated functionality, we now instead set CMAKE_MACOSX_RPATH to OFF, which should have the same effect. Besides removing deprecated behavior, this has the nice side effect of removing the warnings that were emitted when building the cpp runtime with cmake. Signed-off-by: Robert Adam <dev@robert-adam.de>
- Loading branch information