fix(auth): simplify provider handling with URL-based configuration #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor provider service to support multiple authentication methods\n- Add support for Antinomy provider\n- Update OpenRouter URL from api.openrouter.io to openrouter.ai\n- Improve provider architecture with generics\n- Add force_antinomy flag for environment configuration\n- Restructure client builder pattern for better type safety
tusharmath
changed the title
…der configuration
- Remove serde feature from url dependency - Remove Serialize, Deserialize and From derives from Provider enum - Extract provider resolution logic to a separate method
tusharmath
commented
Mar 7, 2025
crates/forge_infra/src/env.rs
Outdated
| @@ -33,14 +33,24 @@ impl ForgeEnvironmentService { | |||
| fn get(&self) -> Environment { | |||
| dotenv::dotenv().ok(); | |||
| let cwd = std::env::current_dir().unwrap_or(PathBuf::from(".")); | |||
There was a problem hiding this comment.
Provider can store the key.
|
Added a new commit to further simplify the Provider implementation:
This continues the refactoring work to streamline the authentication system. |
tusharmath
commented
Mar 7, 2025
| )), | ||
|
|
||
| forge_domain::Provider::Anthropic => Ok(Client::Anthropic( | ||
| Anthropic::builder().api_key(api_key).build()?, |
There was a problem hiding this comment.
Use a derived builder.
- Restructure Provider enum to include API keys in its variants - Remove dependency on Infrastructure in ForgeProviderService - Update Environment to store Provider instance instead of separate URL and key - Add serde feature to URL dependency for serialization support - Update tests to use the new Provider structure - Simplify client builder to get API key directly from Provider
…r handling - Remove mutex and lazy initialization in ForgeProviderService - Add key() and is_antinomy() helper methods to Provider struct - Replace ClientBuilder with simpler Client::new() constructor - Update AnthropicBuilder to use derive_builder::Builder - Improve URL handling in OpenRouter implementation
| } | ||
| if self.provider.is_open_router() | self.provider.is_antinomy() { | ||
| // For Eg: https://openrouter.ai/api/v1/parameters/google/gemini-pro-1.5-exp | ||
| let path = format!("parameters/{}", model.as_str()); |
There was a problem hiding this comment.
Suggested change
| let path = format!("parameters/{}", model.as_str()); | |
| let path = if self.provider.is_antinomy() { | |
| format!("model/{}/parameters", model.as_str()) | |
| } else { | |
| format!("parameters/{}", model.as_str()) | |
| }; |
…enhance parameter fetching logic
tusharmath
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the authentication system to use URL-based provider detection instead of enum-based configuration, providing more flexibility in supporting different provider endpoints.
Changes
Testing
The implementation preserves backward compatibility while adding new functionality.