-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(patch): introduce ApplyPatchV2 with enhanced fuzzy matching #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g redundant information
…ynamic replacements
… improved clarity
…mprove snapshot tests
…proved readability and maintainability
…tab characters, mixed unicode, and emojis
588573e
to
da35fc7
Compare
This PR introduces a new version of the patch functionality with several improvements: - Enhanced fuzzy matching with configurable similarity threshold - Better handling of special cases: - Unicode and emoji support - Whitespace preservation - Tab character handling - Multiple line endings (\n, \r, \r\n) - Support for complex operations: - Sequential replacements - Non-overlapping matches - Empty search/replace for append/delete operations - Single line deletion - Comprehensive test coverage with snapshot tests - Improved error handling and validation Breaking Changes: - None. The original ApplyPatch remains unchanged while ApplyPatchV2 is introduced as a new tool Related: #N/A
07f4038
to
9128365
Compare
…nd update documentation
…json-search-replace # Conflicts: # crates/forge_app/src/service/snapshots/forge_app__service__system_prompt__tests__tool_unsupported.snap # crates/forge_tool/src/fs/fs_write.rs # crates/forge_tool/src/fs/snapshots/forge_tool__fs__fs_write__test__fs_write_file_exists.snap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new version of the patch functionality with several improvements:
Breaking Changes:
Testing: