Modify the project to utilize Buffer from globalThis instead of requiring it. #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the requirement for Buffer, now supported on all Node.js versions. Here at TagoIO, we use a custom runtime to run unsafe code, and that library import made it impossible for us to upgrade the version of lora-packet, keeping us on an old version (0.8.15 - that version was using globalThis), because we use a bundle to polyfill buffer dependency.
This change is backward-compatible; all Node.js versions (10.x, 12.x, 14.x, 16.x, 18.x, 20.x, 22.x) are working fine, as you can see in the actions.
In this PR, I also added support for Node 20 and 22 in the CI pipeline.