Replace KEYS and DEL #508
Open
Replace KEYS and DEL #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 19, 2025 20:43
wumuzi520
reviewed
Feb 24, 2025
| }); | ||
| auto reply = promise.get_future().get(); | ||
| const auto &keys = reply->ReadAsStringArray(); | ||
| // Get all keys |
There was a problem hiding this comment.
It's better to add some unit tests.
wumuzi520
reviewed
Feb 27, 2025
| void Scan(const std::function<void()> on_done); | ||
| void OnScanCallback(const std::shared_ptr<CallbackReply> &reply, | ||
| std::function<void()> on_done); | ||
| std::unique_ptr<RedisClient> &redis_client_; |
There was a problem hiding this comment.
Please add some moments to explain there members and methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related to Issue #507
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.