perf: remove avatar sizes from cache (3/4) #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
privatenumber
force-pushed
the
optimize-cache-more
branch
from
46f2aaf to
56e70bc
Compare
privatenumber
changed the title
antfu
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This is a PR against #93
Diff: privatenumber/sponsorkit@webp-sharp...optimize-cache-more
#93 should be merged first
Description
We never need all 3 resolutions for an image so it was wasteful to be processing all 3 image sizes for every avatar
It was also wasteful to store them in the cache
Now, it only stores the highest resolution we need in the cache, and we process the image size we need as we use them. There's a cache to prevent re-computation.
I was able to slim down the code as well because we now no longer need to manage all 3 sizes
I also created a cache parser/stringifier to abstract out the buffer <-> base64 conversion
Results
2.6 MB931 KBLinked Issues
Additional context