-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add endpoint to chain_api that reports active (and pending if different) finalizer policies and each finalizers last tracked vote #453
Conversation
…c http_api endpoint tests
…nna, and plugin_http_category_api_test
plugins/chain_plugin/include/eosio/chain_plugin/tracked_votes.hpp
Outdated
Show resolved
Hide resolved
plugins/chain_plugin/include/eosio/chain_plugin/chain_plugin.hpp
Outdated
Show resolved
Hide resolved
I believe we wanted |
…n_http_category_api_test, and plugin_http_api_test_savanna
key directly (instead of string) as the key for last_votes cache (a map)
chain::block_id_type voted_block_id; | ||
uint32_t voted_block_num{0}; | ||
fc::time_point voted_block_timestamp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these identify the block which was voted on
OR
Do these identify the block that contained the vote
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The block that was voted on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add a comment to the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done by 76d123d
I will do a separate PR for it #464 |
Note:start |
I'd would suggest changing:
Also, could we sort the list of votes according to |
Thanks! I have renamed them as you suggest. I also place Done by f5a5022 |
Awesome, thanks Lin! |
Provide a
chain_api
RPC endpointget_finalizer_info
that reportsResolves #419
A sample output of the endpoint from a test run: