Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint to chain_api that reports active (and pending if different) finalizer policies and each finalizers last tracked vote #419

Closed
arhag opened this issue Jul 26, 2024 · 0 comments · Fixed by #453
Assignees
Labels
enhancement New feature or request 👍 lgtm
Milestone

Comments

@arhag
Copy link
Member

arhag commented Jul 26, 2024

Any history tracked by the chain plugin should be ephemeral (lost when nodeos is shut down). Therefore, there is no guarantee that last tracked vote information will be available for every finalizer in the active (and pending) policy within any particular nodeos instance. So the structure containing the last tracked vote information for each finalizers should be optional; returning nullopt for a particular finalizer does not necessarily mean that the finalizer has not voted yet, it just means this nodeos instance does not know what that finalizer's last tracked vote is.

The last tracked vote associated with each finalizer (if present) should include the timestamp, block ID, and block number of that block it last voted on, and it should also indicate whether that vote was strong or weak and the generation number of the policy it voted as part of (pick the pending over the active if the finalizer was present in both).

@arhag arhag added this to the Savanna: Cusp milestone Jul 26, 2024
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jul 26, 2024
@arhag arhag changed the title Add endpoint to chain_api that reports active (and pending if different) finalizer policies and each finalizers last tracked vote time Add endpoint to chain_api that reports active (and pending if different) finalizer policies and each finalizers last tracked vote Jul 26, 2024
@arhag arhag added enhancement New feature or request 👍 lgtm and removed triage labels Jul 26, 2024
@linh2931 linh2931 self-assigned this Jul 26, 2024
@linh2931 linh2931 moved this from Todo to In Progress in Team Backlog Jul 26, 2024
@BenjaminGormanPMP BenjaminGormanPMP moved this from In Progress to Awaiting Review in Team Backlog Aug 1, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 👍 lgtm
Projects
Archived in project
3 participants