Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export deps plugins for further customizing by instaceof #264

Merged
merged 4 commits into from
Apr 18, 2017

Conversation

jaredleechn
Copy link
Member

@coveralls
Copy link

coveralls commented Apr 17, 2017

Coverage Status

Coverage remained the same at 81.379% when pulling defc4f5 on feat/exportDeps into befc3b0 on master.

@jaredleechn
Copy link
Member Author

jaredleechn commented Apr 17, 2017

这种写法好像可能会导致 breakchange

import webpack, { ProgressPlugin, ExtractTextPlugin } from 'atool-build/lib/webpack';

这种写法的 ProgressPlugin 就拿不到了,必须 webpack.ProgressPlugin 才可以

要不我新加个文件,叫做 deps 来专门 export 依赖?

@coveralls
Copy link

coveralls commented Apr 17, 2017

Coverage Status

Coverage remained the same at 81.379% when pulling daf6b54 on feat/exportDeps into befc3b0 on master.

jaredleechn added a commit to ant-tool/atool-doc that referenced this pull request Apr 17, 2017
@coveralls
Copy link

coveralls commented Apr 17, 2017

Coverage Status

Coverage remained the same at 81.379% when pulling aed9ce3 on feat/exportDeps into befc3b0 on master.

@soda-x soda-x merged commit ef2f969 into master Apr 18, 2017
@soda-x soda-x deleted the feat/exportDeps branch April 18, 2017 02:54
jaredleechn added a commit to ant-tool/atool-doc that referenced this pull request Apr 28, 2017
 (#43)

* refactor: extend instead of replacing, relative ant-tool/atool-build#264

* fix: peerDeps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants