Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typography copyable icon not aligned #51066

Merged
merged 3 commits into from
Sep 29, 2024
Merged

fix: Typography copyable icon not aligned #51066

merged 3 commits into from
Sep 29, 2024

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Sep 29, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

  • Describe the source of related requirements, such as links to relevant issue discussions.
  • For example: close #xxxx, fix #xxxx

close #50240

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

Revert #49221

📝 Change Log

Language Changelog
🇺🇸 English Revert #49221 to fix Typography copyable icon align issue.
🇨🇳 Chinese 回滚 #49221 以修复 Typography copyable 图标位置偏上的问题。

Copy link

stackblitz bot commented Sep 29, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Sep 29, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Sep 29, 2024

👁 Visual Regression Report for PR #51066 Failed ❌

🎯 Target branch: master (80b6157)
📖 View Full Report ↗︎

Expected (Branch master) Actual (Current PR) Diff
input-align.compact.png input-align.compact.png input-align.compact.png input-align.compact.png
input-align.compact.png input-align.compact.png input-align.compact.css-var.png input-align.compact.css-var.png
input-align.dark.png input-align.dark.png input-align.dark.png input-align.dark.png
input-align.dark.png input-align.dark.png input-align.dark.css-var.png input-align.dark.css-var.png
input-align.default.png input-align.default.png input-align.default.png input-align.default.png
input-align.default.png input-align.default.png input-align.default.css-var.png input-align.default.css-var.png
typography-copyable.compact.png typography-copyable.compact.png typography-copyable.compact.png typography-copyable.compact.png
typography-copyable.compact.png typography-copyable.compact.png typography-copyable.compact.css-var.png typography-copyable.compact.css-var.png
typography-copyable.dark.png typography-copyable.dark.png typography-copyable.dark.png typography-copyable.dark.png
typography-copyable.dark.png typography-copyable.dark.png typography-copyable.dark.css-var.png typography-copyable.dark.css-var.png

Check Full Report for details


If you think the visual diff is acceptable, please check:

  • Visual diff is acceptable

Copy link
Contributor

github-actions bot commented Sep 29, 2024

size-limit report 📦

Path Size
dist/antd.min.js 440.43 KB
dist/antd-with-locales.min.js 508.1 KB

Copy link

cloudflare-workers-and-pages bot commented Sep 29, 2024

Deploying ant-design with  Cloudflare Pages  Cloudflare Pages

Latest commit: de1a9b7
Status: ✅  Deploy successful!
Preview URL: https://b4201b2c.ant-design.pages.dev
Branch Preview URL: https://fix-copyable-align.ant-design.pages.dev

View logs

Copy link

pkg-pr-new bot commented Sep 29, 2024

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (80b6157) to head (de1a9b7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #51066   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          762       762           
  Lines        13524     13524           
  Branches      3514      3514           
=========================================
  Hits         13524     13524           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit c063168 into master Sep 29, 2024
64 checks passed
@afc163 afc163 deleted the fix/copyable-align branch September 29, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paragraph copyable 图标高度没对齐
2 participants