Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tree switch bg height #50313

Merged
merged 2 commits into from
Aug 8, 2024
Merged

fix: tree switch bg height #50313

merged 2 commits into from
Aug 8, 2024

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 8, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • 🆕 New feature
  • 🐞 Bug fix
  • 📝 Site / documentation improvement
  • 📽️ Demo improvement
  • 💄 Component style improvement
  • 🤖 TypeScript definition improvement
  • 📦 Bundle size optimization
  • ⚡️ Performance optimization
  • ⭐️ Feature enhancement
  • 🌐 Internationalization
  • 🛠 Refactoring
  • 🎨 Code style optimization
  • ✅ Test Case
  • 🔀 Branch merge
  • ⏩ Workflow
  • ❓ Other (about what?)

🔗 Related Issues

fix #50255

💡 Background and Solution

  • The specific problem to be addressed.
  • List the final API implementation and usage if needed.
  • If there are UI/interaction changes, consider providing screenshots or GIFs.

📝 Change Log

Language Changelog
🇺🇸 English Fix Tree switcher position not ping at top when title break the line.
🇨🇳 Chinese 修复 Tree 展开按钮在标题折行时没有顶上对齐的问题。

Copy link

stackblitz bot commented Aug 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Aug 8, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Aug 8, 2024

👁 Visual Regression Report for PR #50313 Passed ✅

🎯 Target branch: master (dd3bfae)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Aug 8, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 346.06 KB (+5 B 🔺)
./dist/antd-with-locales.min.js 396.92 KB (+84 B 🔺)

Copy link

pkg-pr-new bot commented Aug 8, 2024

@crazyair
Copy link
Member

crazyair commented Aug 8, 2024

像这个,就可以写 debug demo,截图,避免后续出现

@crazyair
Copy link
Member

crazyair commented Aug 8, 2024

image

换行的会不会有问题

@zombieJ
Copy link
Member Author

zombieJ commented Aug 8, 2024

像这个,就可以写 debug demo,截图,避免后续出现

现在看也是这样子的,它是 hover 才能发现区别

@crazyair
Copy link
Member

crazyair commented Aug 8, 2024

像这个,就可以写 debug demo,截图,避免后续出现

现在看也是这样子的,它是 hover 才能发现区别

这个 demo 不需要 hover 也能展示,就用这个 demo 加个 debug,防止后续出现
image

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dd3bfae) to head (454ae89).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #50313   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          751       751           
  Lines        13139     13181   +42     
  Branches      3428      3449   +21     
=========================================
+ Hits         13139     13181   +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

afc163
afc163 previously approved these changes Aug 8, 2024
@afc163
Copy link
Member

afc163 commented Aug 8, 2024

不对,diff 有问题。

@crazyair
Copy link
Member

crazyair commented Aug 8, 2024

不对,diff 有问题。

刚想说

@zombieJ
Copy link
Member Author

zombieJ commented Aug 8, 2024

不对,diff 有问题。

现在知道为什么需要拉长了

@zombieJ
Copy link
Member Author

zombieJ commented Aug 8, 2024

switch 本身需要划线,所以给 switch 加个伪类来实现 hover 包包的效果。

@zombieJ zombieJ merged commit 0cf4a27 into master Aug 8, 2024
77 checks passed
@zombieJ zombieJ deleted the fix-tree-switcher branch August 8, 2024 12:21
linxianxi pushed a commit to linxianxi/ant-design that referenced this pull request Aug 14, 2024
* fix: tree switch bg height

* fix: use before instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree: draggable and expandable icons are not vertically aligned
4 participants