Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CP support Tag closeIcon #47250

Merged
merged 1 commit into from
Jan 31, 2024
Merged

feat: CP support Tag closeIcon #47250

merged 1 commit into from
Jan 31, 2024

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Jan 30, 2024

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English feat: CP support Tag closeIcon
🇨🇳 Chinese feat: CP support Tag closeIcon

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Jan 30, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Jan 30, 2024

Preview Is ready

Copy link
Contributor

github-actions bot commented Jan 30, 2024

Visual Regression Report for PR #47250 Passed ✅

Target branch: feature (b233f27)


Congrats! No visual-regression diff found

Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 333 KB (+128 B 🔺)
./dist/antd-with-locales.min.js 378.65 KB (-146 B 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ee4976a:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b233f27) 100.00% compared to head (ee4976a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #47250   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          734       734           
  Lines        12584     12585    +1     
  Branches      3293      3294    +1     
=========================================
+ Hits         12584     12585    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 651914c into feature Jan 31, 2024
113 checks passed
@MadCcc MadCcc deleted the Tag-closeIcon branch January 31, 2024 02:07
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants