Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Menu support darkPopupBg token #46618

Merged
merged 4 commits into from
Dec 29, 2023
Merged

feat: Menu support darkPopupBg token #46618

merged 4 commits into from
Dec 29, 2023

Conversation

chenshuai2144
Copy link
Contributor

@chenshuai2144 chenshuai2144 commented Dec 25, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English feat: Menu support darkPopupBg token
🇨🇳 Chinese Menu 支持 darkPopupBg 的 token 配置

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Dec 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Dec 25, 2023

Visual Regression Report for PR #46618 Failed ❌

Target branch: feature (87adc38)
View Full Report


image name expected actual diff
menu-component-token.png feature: 87adc388d52af66c2b4118516856b91e3b6106bd current: pr-46618 diff
menu-component-token.css-var.png feature: 87adc388d52af66c2b4118516856b91e3b6106bd current: pr-46618 diff

Check Full Report for details

Copy link
Contributor

github-actions bot commented Dec 25, 2023

Preview Is ready

@chenshuai2144 chenshuai2144 changed the base branch from master to feature December 25, 2023 14:22
@chenshuai2144 chenshuai2144 marked this pull request as ready for review December 25, 2023 14:26
Copy link

codesandbox-ci bot commented Dec 25, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bc113a0:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link
Contributor

github-actions bot commented Dec 25, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 329.99 KB (-61 B 🔽)
./dist/antd-with-locales.min.js 376.09 KB (+282 B 🔺)

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87adc38) 100.00% compared to head (bc113a0) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #46618   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          718       718           
  Lines        12209     12209           
  Branches      3223      3223           
=========================================
  Hits         12209     12209           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 968200d into feature Dec 29, 2023
104 of 105 checks passed
@MadCcc MadCcc deleted the feat-darkPopupBg branch December 29, 2023 08:49
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants