Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Form sm 24 not working #44541

Merged
merged 2 commits into from
Aug 31, 2023
Merged

fix: Form sm 24 not working #44541

merged 2 commits into from
Aug 31, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 30, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #44538

💡 Background and solution

v4 is correct https://github.com/ant-design/ant-design/blob/4.x-stable/components/form/style/horizontal.less#L18

📝 Changelog

Language Changelog
🇺🇸 English Fix Form wrapperCol to be 24 not working when labelCol is set to 24.
🇨🇳 Chinese 修复 Form labelCol 设置为 24 时,会使 wrapperCol 设置 24 失效的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 609c5d0

Fixed a form style bug and removed unused code in components/form/style/index.ts. The bug caused incorrect label alignment for some custom classes.

🔍 Walkthrough

🤖 Generated by Copilot at 609c5d0

  • Fix form item control style for custom label class names that end with or contain -24 (link)
  • Remove unused rootPrefixCls variable from genHorizontalStyle function (link)

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

@stackblitz
Copy link

stackblitz bot commented Aug 30, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 389.52 KB (+13 B 🔺)
./dist/antd-with-locales.min.js 448.38 KB (+16 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 1 change Aug 30, 2023, 4:13 PM

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e88581c) 100.00% compared to head (0256315) 100.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44541   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          665       665           
  Lines        11276     11304   +28     
  Branches      3048      3063   +15     
=========================================
+ Hits         11276     11304   +28     
Files Changed Coverage Δ
components/form/style/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

labelCol and wrapperCol issue with responsive design
3 participants