Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inputNumber has 1px difference with input on the baseline #43534

Closed
wants to merge 1 commit into from

Conversation

bbb169
Copy link
Contributor

@bbb169 bbb169 commented Jul 13, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#43528

💡 Background and solution

add 'verticalAlign: 'bottom' css style for class ’ant-input-number‘

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • [x ] Doc is updated/provided or not needed
  • [ x] Demo is updated/provided or not needed
  • [ x] TypeScript definition is updated/provided or not needed
  • [ x] Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 978286a

Fix input number alignment with suffix icon. Add verticalAlign style to components/input-number/style/index.ts to adjust the position of the input number component.

🔍 Walkthrough

🤖 Generated by Copilot at 978286a

  • Align input number with suffix icon by adding verticalAlign style (link)

@stackblitz
Copy link

stackblitz bot commented Jul 13, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

  • 🚨 Please fill changelog in the PR

    • Write with a developer-oriented perspective and narrative method, without describing the details of the repair
    • Describing the problem and the impact on the developer
    • describing the user-first site problem, not your solution
    • Refer: https://ant.design/changelog#501
  • 🚨 请填写 PR 中的 changelog

    • 请用面向开发者的角度叙述方式撰写,不描述修复细节
    • 描述问题和对开发者的影响
    • 描述用户第一现场的问题,而非你的解决方式
    • 参考:https://ant.design/changelog-cn#501

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3f92966) 100.00% compared to head (978286a) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #43534   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          648       657    +9     
  Lines        10957     11047   +90     
  Branches      2975      2990   +15     
=========================================
+ Hits         10957     11047   +90     
Impacted Files Coverage Δ
components/input-number/style/index.ts 100.00% <ø> (ø)

... and 145 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -62,6 +62,7 @@ const genInputNumberStyles: GenerateStyle<InputNumberToken> = (token: InputNumbe
padding: 0,
border: `${lineWidth}px ${lineType} ${colorBorder}`,
borderRadius,
verticalAlign: 'bottom',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不应该动这个,这个会导致和其他组件对不齐。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

解法在 #43528 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

图片

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

新解法已提 #43548

@bbb169 bbb169 closed this Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants