-
-
Notifications
You must be signed in to change notification settings - Fork 50.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ColorPicker implement panelRender
API
#43134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #43134 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 654 657 +3
Lines 11002 11018 +16
Branches 2983 2986 +3
=========================================
+ Hits 11002 11018 +16
☔ View full report in Codecov by Sentry. |
MadCcc
reviewed
Jun 21, 2023
冲突了 |
刚合了另一个 pr 我一会处理一下 |
RedJue
force-pushed
the
feature-color-picker-panelrender
branch
2 times, most recently
from
June 24, 2023 15:06
072ad90
to
5f21f87
Compare
MadCcc
reviewed
Jun 25, 2023
MadCcc
reviewed
Jun 25, 2023
RedJue
force-pushed
the
feature-color-picker-panelrender
branch
from
June 25, 2023 06:22
3339fb2
to
2f4b31b
Compare
MadCcc
reviewed
Jun 25, 2023
RedJue
force-pushed
the
feature-color-picker-panelrender
branch
from
June 26, 2023 03:58
473a785
to
814c1c6
Compare
MadCcc
reviewed
Jun 26, 2023
RedJue
force-pushed
the
feature-color-picker-panelrender
branch
2 times, most recently
from
June 27, 2023 06:56
a0b836f
to
eb481ec
Compare
MadCcc
reviewed
Jun 27, 2023
RedJue
force-pushed
the
feature-color-picker-panelrender
branch
2 times, most recently
from
June 28, 2023 10:27
708040f
to
35f4a80
Compare
RedJue
force-pushed
the
feature-color-picker-panelrender
branch
from
June 29, 2023 03:04
960f2b0
to
29c8ca8
Compare
MadCcc
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#42749
[RFC] ColorPicker implement panelRender API
💡 Background and solution
Add title
Horizontal layout
📝 Changelog
panelRender
APIpanelRender
API☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at f75c89f
Added a
panelRender
prop to theColorPicker
component to enable custom panel rendering. Created new components and contexts to support the prop and its functionality. Added a new demo and updated the documentation to show the usage of the prop and its custom components. Fixed a style conflict between thePopover
and theRcColorPicker
components.🔍 Walkthrough
🤖 Generated by Copilot at f75c89f
panelRender
prop toColorPicker
component to allow customizing the color picker panel (link, link, link)panelRender
prop toRcColorPicker
component and renamestyle
prop tooverlayInnerStyle
forPopover
component (link, link)ColorPickerPanel
component to usePanelPicker
andPanelPresets
components and their context providers (link, link)PanelPicker
component to renderColorClear
,ColorInput
, andpanel
prop fromRcColorPicker
component usingPanelPickerContext
(link, link)PanelPresets
component to renderColorPresets
component usingPanelPresetsContext
(link, link)display
andflexDirection
styles from${componentCls}-panel
selector to${componentCls}-inner-panel
selector incomponents/color-picker/style/index.ts
(link)panelRender
prop and its custom components incomponents/color-picker/__tests__/index.test.tsx
(link)panelRender
prop and its custom components incomponents/color-picker/demo/panel-render.md
,components/color-picker/demo/panel-render.tsx
, andcomponents/color-picker/index.zh-CN.md
(link, link, link)