fix: ColorPicker presets cannot be selected #42882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Pull reviewers statsStats of the last 30 days for ant-design:
|
RedJue
changed the title
yoyo837
reviewed
Jun 7, 2023
| })), | ||
| [], | ||
| ); | ||
| const items: CollapseProps['items'] = presetsValue.map((preset) => ({ |
There was a problem hiding this comment.
逻辑里有需要实时判断 value 的，所以加不加区别不大，value 变了就要重新循环。
size-limit report 📦
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #42882 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 715 715
Lines 64206 64199 -7
Branches 4753 4752 -1
=========================================
- Hits 64206 64199 -7
☔ View full report in Codecov by Sentry. |
|
测试用例补一下吧 |
RedJue
force-pushed
the
fix-color-picker-presets-not-checked
branch
from
ac6c90a
to
df882d5
Compare
….com/ant-design/ant-design into fix-color-picker-presets-not-checked
MadCcc
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at f5f4df7
Removed
useMemohook fromitemsvariable incomponents/color-picker/components/ColorPresets.tsxto fix a bug with color preset panels. This was part of a pull request to enhance the color picker component.🔍 Walkthrough
🤖 Generated by Copilot at f5f4df7
useMemohook fromitemsvariable to fix panel update bug (link)