fix: 修复 Tag onClick 为 undefined，鼠标点击也会出现边框样式 #40023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
size-limit report 📦
|
Codecov ReportBase: 99.99% // Head: 100.00% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #40023 +/- ##
========================================
Coverage 99.99% 100.00%
========================================
Files 603 603
Lines 10256 10261 +5
Branches 2728 2733 +5
========================================
+ Hits 10255 10261 +6
+ Misses 1 0 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yoyo837
reviewed
Jan 5, 2023
github-actions
bot
added
codeball:needs-careful-review
and removed
codeball:needs-review
labels
yoyo837
approved these changes
Jan 5, 2023
afc163
reviewed
Jan 5, 2023
| @@ -119,7 +119,8 @@ const InternalTag: React.ForwardRefRenderFunction<HTMLSpanElement, TagProps> = ( | |||
| }; | |||
|
|
|||
| const isNeedWave = | |||
| 'onClick' in props || (children && (children as React.ReactElement<any>).type === 'a'); | |||
| typeof props.onClick === 'function' || | |||
| (children && (children as React.ReactElement<any>).type === 'a'); | |||
There was a problem hiding this comment.
<Tooltip title="title">
<Tag>demo</Tag>
</Tooltip>hover 的 Tooltip，会给 children 注入 onClick，导致鼠标点击 Tag 会出现边框样式
crazyair
changed the title
SohaibRaza
pushed a commit
to SohaibRaza/ant-design
that referenced
this pull request
Jan 6, 2023
* fix: 修复 Tag onClick 为 undefined 的判断方式 * feat: function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge