Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(popconfirm): make title bold and add description prop #39250

Merged
merged 8 commits into from
Dec 8, 2022

Conversation

xhh0223
Copy link
Contributor

@xhh0223 xhh0223 commented Dec 4, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Popconfirm title and description props

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Popconfirm supports description prop now.
🇨🇳 Chinese Popconfirm 组件新增 description 属性。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2022

@xhh0223 xhh0223 changed the title feat: Popconfirm title and description props feat(Popconfirm) make title bold and add description prop Dec 4, 2022
@xhh0223 xhh0223 changed the title feat(Popconfirm) make title bold and add description prop feat(popconfirm) make title bold and add description prop Dec 4, 2022
@xhh0223 xhh0223 changed the title feat(popconfirm) make title bold and add description prop feat(popconfirm): make title bold and add description prop Dec 4, 2022
afc163
afc163 previously approved these changes Dec 5, 2022
components/popconfirm/PurePanel.tsx Outdated Show resolved Hide resolved
@afc163
Copy link
Member

afc163 commented Dec 5, 2022

哦,发到 feature 分支吧。

@xhh0223 xhh0223 changed the base branch from master to feature December 5, 2022 05:07
@xhh0223
Copy link
Contributor Author

xhh0223 commented Dec 5, 2022

@afc163 已squash并发到feature分支了

@afc163
Copy link
Member

afc163 commented Dec 5, 2022

可以修改一下所有 demo,加上 description

@xhh0223
Copy link
Contributor Author

xhh0223 commented Dec 5, 2022

@afc163 已添加demos提交

@afc163
Copy link
Member

afc163 commented Dec 5, 2022

npm test -- components/popconfirm -u 更新一下 snapshot 。

@xhh0223
Copy link
Contributor Author

xhh0223 commented Dec 6, 2022

@afc163 snapshot 已更新

@afc163
Copy link
Member

afc163 commented Dec 6, 2022

table 和 space 里也要更新

@xhh0223
Copy link
Contributor Author

xhh0223 commented Dec 6, 2022

@afc163 我走了一遍所有的test更新

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (62f0c5a) compared to base (816cf10).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #39250   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          550       550           
  Lines         9431      9433    +2     
  Branches      2681      2683    +2     
=========================================
+ Hits          9431      9433    +2     
Impacted Files Coverage Δ
components/popconfirm/index.tsx 100.00% <ø> (ø)
components/popconfirm/PurePanel.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163
Copy link
Member

afc163 commented Dec 6, 2022

为popconfirm组件添加description属性,并为标题加粗

Popconfirm 组件新增 description 属性。

@afc163
Copy link
Member

afc163 commented Dec 7, 2022

冲突了,合并一下 feature

@xhh0223
Copy link
Contributor Author

xhh0223 commented Dec 7, 2022

好的。

@xhh0223
Copy link
Contributor Author

xhh0223 commented Dec 7, 2022

@afc163 好了

@xhh0223
Copy link
Contributor Author

xhh0223 commented Dec 7, 2022

@afc163 好了

我这里是把远端的feature都更新,发现只有快照冲突,然后接受feature的快照,自己重新跑一边test:update

@afc163
Copy link
Member

afc163 commented Dec 7, 2022

还有一处 snapshot 未更新

@xhh0223
Copy link
Contributor Author

xhh0223 commented Dec 7, 2022

还有一处 snapshot 未更新

感觉有点奇怪所有的都跑了一边,不知道还有哪出没更新,可能是本地跑着很长然后失败了
38
原来是新的feature多了包,需要安装下依赖

@afc163 已更

辛苦大佬多次review☺

@afc163 afc163 merged commit 451d2f6 into ant-design:feature Dec 8, 2022
@afc163
Copy link
Member

afc163 commented Dec 8, 2022

合并了!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants