Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Modal.xxx supports footer #39048

Merged
merged 11 commits into from
Dec 7, 2022
Merged

Conversation

owjs3901
Copy link
Contributor

@owjs3901 owjs3901 commented Nov 28, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Modal func has not footer props. Therefore Modal footer created by modal func cannot be modified.

Finnaly I add footer props to Modal Func.

📝 Changelog

Language Changelog
🇺🇸 English Modal.comfirm support footer now.
🇨🇳 Chinese Modal.confirm 新增 footer 属性以自定义按钮列表。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2022

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (f71c9d7) compared to base (240210a).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head f71c9d7 differs from pull request most recent head 709cbd8. Consider uploading reports for the commit 709cbd8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #39048   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          548       548           
  Lines         9407      9409    +2     
  Branches      2675      2677    +2     
=========================================
+ Hits          9407      9409    +2     
Impacted Files Coverage Δ
components/modal/Modal.tsx 100.00% <ø> (ø)
components/modal/ConfirmDialog.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163
Copy link
Member

afc163 commented Dec 3, 2022

  1. Please add test case.
  2. Documentation should be updated.

@owjs3901
Copy link
Contributor Author

owjs3901 commented Dec 3, 2022

  1. Please add test case.
  2. Documentation should be updated.

OK! I will try!

package.json Outdated Show resolved Hide resolved
@afc163
Copy link
Member

afc163 commented Dec 5, 2022

feature branch

@owjs3901 owjs3901 changed the base branch from master to feature December 5, 2022 05:38
@owjs3901
Copy link
Contributor Author

owjs3901 commented Dec 5, 2022

I changed branch

@owjs3901 owjs3901 requested a review from afc163 December 5, 2022 05:39
@owjs3901 owjs3901 requested a review from afc163 December 5, 2022 08:58
@owjs3901
Copy link
Contributor Author

owjs3901 commented Dec 6, 2022

@afc163 Completed!

@afc163 afc163 changed the title Add Func Modal footer feat: Modal.xxx supports footer Dec 7, 2022
@afc163 afc163 merged commit a836a3a into ant-design:feature Dec 7, 2022
@owjs3901 owjs3901 deleted the feat/modal_footer branch December 9, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants