Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tooltip arrowPointAtCenter 1px shift bug #31201

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jun 30, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #31197

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tooltip arrowPointAtCenter 1px shift bug
🇨🇳 Chinese 修复 Tooltip arrowPointAtCenter 有一像素偏移的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2021

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #31201 (6b0833a) into master (4e12007) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #31201   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          397       397           
  Lines         7561      7596   +35     
  Branches      2074      2092   +18     
=========================================
+ Hits          7561      7596   +35     
Impacted Files Coverage Δ
components/tooltip/placements.tsx 100.00% <100.00%> (ø)
components/form/FormItem.tsx 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e12007...6b0833a. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: -4 B (0%)

Total Size: 832 kB

Filename Size Change
./dist/antd-with-locales.min.js 341 kB -2 B (0%)
./dist/antd.min.js 297 kB -2 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/antd.compact.min.css 64.2 kB
./dist/antd.dark.min.css 65.5 kB
./dist/antd.min.css 64.4 kB

compressed-size-action

@afc163 afc163 merged commit 19cd351 into master Jun 30, 2021
@afc163 afc163 deleted the fix-arrowPointAtCenter branch June 30, 2021 03:48
yingpengsha pushed a commit to yingpengsha/ant-design that referenced this pull request Jul 2, 2021
@zombieJ zombieJ mentioned this pull request Jul 12, 2021
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Tooltip component is not set to the center of the child component if the arrowPointAtCenter props is true
1 participant