Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not found content should be disabled #28062

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

headwindz
Copy link
Contributor

@headwindz headwindz commented Nov 28, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Cascader组件options为空数组时,暂无数据作为了下拉选项(可选项)

close #27949

💡 Background and solution

Make Not found content disabled, just like it's done in filter nodes.

📝 Changelog

Language Changelog
🇺🇸 English Fix Cascader bug that empty data can be selected.
🇨🇳 Chinese 修复 Cascader 空数据可以被选择的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Nov 28, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f8e0e86:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Nov 28, 2020

Codecov Report

Merging #28062 (f8e0e86) into master (4f811cb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #28062   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7339      7340    +1     
  Branches      2045      2097   +52     
=========================================
+ Hits          7339      7340    +1     
Impacted Files Coverage Δ
components/cascader/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f811cb...f8e0e86. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Nov 30, 2020

让 暂无数据 不可选中

修复 Cascader 空数据可以被选择的问题。

@headwindz
Copy link
Contributor Author

让 暂无数据 不可选中

修复 Cascader 空数据可以被选择的问题。

done

@afc163 afc163 merged commit 73a07d0 into ant-design:master Nov 30, 2020
@zombieJ zombieJ mentioned this pull request Nov 30, 2020
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cascader组件options为空数组时,暂无数据作为了下拉选项(可选项)
3 participants