Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix destroyFns not reduce when instance.destroy() #14600

Merged
merged 2 commits into from
Jan 30, 2019

Conversation

xu-snow
Copy link
Contributor

@xu-snow xu-snow commented Jan 28, 2019

This is a ...

  • Bug fix

What's the background?

  1. in confirm.destroy(), destroyFns will never contain destroy , it is simple code problem, destroyFns contain close instead
  2. it will make the destroyFns not change when user manually close confirm dialog

Changelog description (Optional if not new feature)

  1. fixbug,confirm destroy() has unreachable code
  2. fixbug, 销毁对话框函数 destroy() 有永远不会执行到的代码块

Self Check before Merge

  • Doc is or not needed
  • Demo not needed
  • TypeScript not needed
  • Changelog not needed

@netlify
Copy link

netlify bot commented Jan 28, 2019

Deploy preview for ant-design ready!

Built with commit 3e06070

https://deploy-preview-14600--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #14600 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14600   +/-   ##
=======================================
  Coverage   94.43%   94.43%           
=======================================
  Files         333      333           
  Lines        7264     7264           
  Branches     1788     1821   +33     
=======================================
  Hits         6860     6860           
  Misses        389      389           
  Partials       15       15
Impacted Files Coverage Δ
components/modal/confirm.tsx 96.77% <100%> (+3.22%) ⬆️
components/upload/UploadList.tsx 88.03% <0%> (-1.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a379c47...3e06070. Read the comment docs.

@ycjcl868
Copy link
Contributor

close is right.

image

@zombieJ zombieJ merged commit b3df86a into ant-design:master Jan 30, 2019
@xu-snow xu-snow deleted the fix-confirm-destory branch January 30, 2019 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants