Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow vertical form labels to break line #14135

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

ranbena
Copy link
Contributor

@ranbena ranbena commented Jan 6, 2019

This is a Bug fix

Background

In horizontal forms, labels are cut short so as to not break the layout if text is long.
But in vertical form layouts this feature is an unnecessary limitation.

50728505-fdb31900-1111-11e9-9dde-6dcb1dd34c00

API Realization

A one line addition to return white-space to initial value when in vertical layout.

Self Check before Merge

This change will be pretty much invisible as it is mostly an edge case. No docs, demo or definition needed.

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog provided

@netlify
Copy link

netlify bot commented Jan 6, 2019

Deploy preview for ant-design ready!

Built with commit 4a5e681

https://deploy-preview-14135--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Jan 6, 2019

Codecov Report

Merging #14135 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14135   +/-   ##
=======================================
  Coverage   94.16%   94.16%           
=======================================
  Files         325      325           
  Lines        7108     7108           
  Branches     1757     1757           
=======================================
  Hits         6693     6693           
  Misses        403      403           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 726c037...4a5e681. Read the comment docs.

3 similar comments
@codecov
Copy link

codecov bot commented Jan 6, 2019

Codecov Report

Merging #14135 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14135   +/-   ##
=======================================
  Coverage   94.16%   94.16%           
=======================================
  Files         325      325           
  Lines        7108     7108           
  Branches     1757     1757           
=======================================
  Hits         6693     6693           
  Misses        403      403           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 726c037...4a5e681. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 6, 2019

Codecov Report

Merging #14135 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14135   +/-   ##
=======================================
  Coverage   94.16%   94.16%           
=======================================
  Files         325      325           
  Lines        7108     7108           
  Branches     1757     1757           
=======================================
  Hits         6693     6693           
  Misses        403      403           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 726c037...4a5e681. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 6, 2019

Codecov Report

Merging #14135 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14135   +/-   ##
=======================================
  Coverage   94.16%   94.16%           
=======================================
  Files         325      325           
  Lines        7108     7108           
  Branches     1757     1757           
=======================================
  Hits         6693     6693           
  Misses        403      403           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 726c037...4a5e681. Read the comment docs.

@afc163 afc163 merged commit 380b8f8 into ant-design:master Jan 7, 2019
@ranbena ranbena deleted the vertical-white-space branch January 7, 2019 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants