Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grid示例中的Carousel没有swipeLock的设定 , 还有点击时候的按压感觉不应该在不判断方向的时候就触发~ #1974

Closed
deepkolos opened this issue Oct 22, 2017 · 7 comments
Closed

grid示例中的Carousel没有swipeLock的设定 , 还有点击时候的按压感觉不应该在不判断方向的时候就触发~ #1974

deepkolos opened this issue Oct 22, 2017 · 7 comments
Labels
enhancement

Comments

@deepkolos
Copy link

deepkolos commented Oct 22, 2017 •
edited
Loading

Version

2.0.0

Environment

win10 1703 chrome 62 stable

Reproduction link

https://mobile.ant.design/kitchen-sink/components/grid?lang=zh-CN

Steps to reproduce

看gif~

What is expected?

左右滑动操作Carousel的时候不会触发scroll , 上下scroll的时候不会触发Carousel

同时就是是否触发按压效果需要判断是否是滑动的~
这个行为可以参考:active属性, 浏览器的原生也是都这一层判断, 不过在移动端dom有寻址和click不同的问题, 希望实现的时候可以避免~

What is actually happening?

都触发了

bug8
@ant-design-bot
Copy link

It will be better to write your issue/comment in English, so more people can understand you.
And this means that more people can help you or benefit from your issue/comment.
See: ant-design/ant-design#4897

@deepkolos
Copy link
Author

deepkolos commented Oct 22, 2017 •
edited
Loading

还有slider一样都swipeLock的问题~ 就补贴图了, 都是小问题~~

应该加横向锁的

补充: 需要设置content的高度,撑出滚动条再测试~

@paranoidjk
Copy link
Contributor

来个 PR？

@deepkolos
Copy link
Author

@paranoidjk 不会react😂 前三个星期才开始学的vue, 现在在给一个vue的组件库做PR, 也是与swipeLock有关. 其实是antd-mobile 来拜师的~ 顺便看看有没有自己遇过的bug, 结果发现有~😂

@silentcloud
Copy link
Contributor

silentcloud commented Oct 25, 2017 •
edited
Loading

grid 这个锁的话，要在 rmc-feedback 加相关一些代码，最后感觉和 rc-touchable 应该错不了多少，我在考虑要不要把 rc-touchable 换回来 @paranoidjk @warmhug
这个改在 rmc-feedback 里

@warmhug
Copy link
Contributor

warmhug commented Oct 25, 2017 •
edited
Loading

能否在 _util 写代码 来解决这个问题。还是不要换回来好。
记得 @zhang740 也遇到过类似问题？关注下

@silentcloud silentcloud self-assigned this Nov 3, 2017
@silentcloud silentcloud added this to the 2.1.0 milestone Nov 3, 2017
silentcloud added a commit to react-component/m-feedback that referenced this issue Nov 9, 2017
@silentcloud
fix: cancel feedback when move (scroll), ref ant-design/ant-design-mo…
d587542 
…bile#1974
@likezero likezero self-assigned this May 22, 2018
This was referenced May 23, 2018
Closed
Closed
@doxiaodong doxiaodong modified the milestones: 2.1.0, 2.2.4 Aug 15, 2018
@doxiaodong
Copy link
Contributor

@likezero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@silentcloud @warmhug @likezero @doxiaodong @paranoidjk @deepkolos @ant-design-bot