Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 增补字库以及修复生僻字输入键盘一些问题 (#844) #845

Merged
merged 7 commits into from
Sep 26, 2023

Conversation

DiamondYuan
Copy link
Collaborator

  • feat: 更新字库数据

  • fix: 增补字库并修复生僻字输入键盘的一些问题

  • fix: 修复单测问题


* feat: 更新字库数据

* fix: 增补字库并修复生僻字输入键盘的一些问题

* fix: 修复单测问题

---------

Co-authored-by: xingying <dikang.lidikang@alibaba-inc.com>
@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2023

🎊 PR Preview 09b2ae5 has been successfully built and deployed to https://ant-design-ant-design-mini-preview-pr-845.surge.sh

🕐 Build time: 647.54s

🤖 By surge-preview

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (2348a89) 83.93% compared to head (6a836e7) 83.66%.

❗ Current head 6a836e7 differs from pull request most recent head 571e3f9. Consider uploading reports for the commit 571e3f9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
- Coverage   83.93%   83.66%   -0.28%     
==========================================
  Files          59       59              
  Lines        1457     1469      +12     
  Branches      442      443       +1     
==========================================
+ Hits         1223     1229       +6     
- Misses        208      214       +6     
  Partials       26       26              
Files Coverage Δ
src/RareWordsKeyboard/zdatas.ts 100.00% <ø> (ø)
src/RareWordsKeyboard/utils.ts 67.52% <33.33%> (-1.23%) ⬇️
src/RareWordsKeyboard/index.ts 74.13% <61.53%> (-2.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DiamondYuan
Copy link
Collaborator Author

  1. 打开 demo 页面
  2. 触发 error
  3. 点击空白隐藏组件

这个时候再次打开键盘,应该 error 为 false ,而字体没有加载完成

@DiamondYuan
Copy link
Collaborator Author

  1. 点击重试以后, showErrorPage 应该改成 false

@DiamondYuan
Copy link
Collaborator Author

希望可以为上面两个场景补上单元测试。

@DiamondYuan
Copy link
Collaborator Author

在测试里 mock loadFontFace, 删掉 hideloading

image

image

@Andyliwr Andyliwr merged commit 48e0a64 into master Sep 26, 2023
@github-actions github-actions bot mentioned this pull request Sep 26, 2023
@DiamondYuan DiamondYuan deleted the rarewords-keyboard-fix branch September 27, 2023 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants