fix: slider #722
Merged
fix: slider #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jc9702507
commented
May 15, 2023
jc9702507
commented
- 修改slider滑动问题
|
🎊 PR Preview ace94e9 has been successfully built and deployed to https://ant-design-ant-design-mini-preview-pr-722.surge.sh 🕐 Build time: 245.939s
🤖 By surge-preview |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| <template name='slider-handler'> | |||
| <view class="ant-slider-handler" style="left: {{position}}%"> | |||
| <popover placement="top" visible="{{showTooltip}}"> | |||
| <popover placement="top" visible="{{showTooltip}}" showMask="{{false}}"> | |||
| <slot name="slider"> | |||
| <view class="ant-slider-handler-block"> | |||
| <view class="ant-slider-handler-icon-default"> | |||
There was a problem hiding this comment.
这个代码补丁只有一行修改。
修改前是没有定义 showMask 属性的，而修改后在 <popover> 中增加了此属性并且赋值为 false。
根据上下文看，我们可以猜测这个属性表示是否显示弹出框背景遮罩。如果不需要这个遮罩，那么将其设置为 false 可以提高用户体验并减轻系统开销。
至于问题和改进建议，目前没有显然的风险或者明显的优化点可以挑选，但是需要根据整个工程的结构和目标来综合考虑补丁的正确性，可读性和完整性。
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #722 +/- ##
=======================================
Coverage 24.01% 24.01%
=======================================
Files 158 158
Lines 3339 3339
Branches 875 875
=======================================
Hits 802 802
Misses 2206 2206
Partials 331 331 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.