fix: 修改 updateScroll 调用时机 #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview 4baf711 has been successfully built and deployed to https://ant-design-ant-design-mini-preview-pr-1110.surge.sh 🕐 Build time: 255.423s
🤖 By surge-preview |
imsenyu
reviewed
Feb 22, 2024
src/Tabs/index.ts
Outdated
| @@ -145,7 +148,7 @@ const Tabs = (props: ITabsProps) => { | |||
| }); | |||
|
|
|||
| /// #if ALIPAY | |||
| useEffect(() => { | |||
| useReady(() => { | |||
There was a problem hiding this comment.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1110 +/- ##
==========================================
- Coverage 89.97% 89.95% -0.03%
==========================================
Files 150 150
Lines 3690 3692 +2
Branches 915 916 +1
==========================================
+ Hits 3320 3321 +1
- Misses 317 318 +1
Partials 53 53 ☔ View full report in Codecov by Sentry. |
DiamondYuan
force-pushed
the
fix-tabs-scroll-time
branch
from
7f7469f to
4baf711
Compare
imsenyu
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在 useEffect ( onInit ) 生命周期调用 updateScroll 的话，有时候会出现元素找不到的情况。