-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Part2] 兼容 component1/component2 适配度 #1098
Conversation
🎊 PR Preview d09288a has been successfully built and deployed to https://ant-design-ant-design-mini-preview-pr-1098.surge.sh 🕐 Build time: 275.574s 🤖 By surge-preview |
|
|
本质需求是兼容 component1 模式的小程序,对吧? 未来如果这批组件里要增加一些逻辑,可能又得切到 functional 的方案上,这时候会产生 breaking change、开发者无法自动升级了 antd-mini v1 升级 v2 的时候,为了避免可能的概念混淆,我们强行要求大家启用 component2 ( https://mini.ant.design/guide/migration-v2 )。现在是有已知的无法升级反馈么? |
有很多待办的事情,包括组件执行及渲染性能优化、多渲染平台样式适配、component1/基础库1.0/基础库2.0低版本适配、集成测试运行环境。以上问题可以归纳为 2 个疑惑
1: 不应该以 component1/2 作为界定判断标准,准确地来说,基础库1.0的component2功能正确性比基础库2.0的component2正确性差很多(尤其是在使用slot的事情),基础库2.0在最近2年的版本内支持了 sjs事件,observers,lifetimes,relations 等生态上有需求的功能。对于一个面向生态的组件库来说,应该做到的是「如果当前基础库支持,直接用;如果当前基础库不支持(包括基础库1.0、钉钉低版本但开发者无法升级)等情况,降级功能达到可用。
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1098 +/- ##
==========================================
- Coverage 89.96% 89.95% -0.02%
==========================================
Files 150 150
Lines 3677 3672 -5
Branches 912 913 +1
==========================================
- Hits 3308 3303 -5
Misses 316 316
Partials 53 53 ☔ View full report in Codecov by Sentry. |
|
那就优化下这个 #1099 |
第二批,如下组件的 Hooks 实现均只有 Event(和计算属性),需要处理好支付宝/微信双端的 props/properties/methods/sjs,并保持 XML 编译不变
支付宝微信双边回归完成后会打钩