Skip to content

Feat/track boolean operations #2153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

smereu
Copy link
Contributor

@smereu smereu commented Aug 5, 2025

Description

This pull request contains the following changes

  • Enable the boolean operation to track changes. When tracking changes it skips clean-up operation on the python side since all the logic resides in the SC APIs.
  • Clean-up code to have a single implementation for serializing the tracked changes.
  • Fixes to the tracker code that deals with added/deleted bodies to keep into account the fact we are caching the bodies so the update needs to be done on the actual data. Also remove use of guids rather than object ids, which prevent proper matching

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@smereu smereu requested a review from a team as a code owner August 5, 2025 18:40
@smereu
Copy link
Contributor Author

smereu commented Aug 5, 2025

This PR needs an update of Core Service code before it can be merged

@github-actions github-actions bot added the enhancement New features or code improvements label Aug 5, 2025
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 52.85714% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.68%. Comparing base (1b3f923) to head (2952b14).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/designer/design.py 24.00% 19 Missing ⚠️
src/ansys/geometry/core/tools/problem_areas.py 11.11% 8 Missing ⚠️
...c/ansys/geometry/core/_grpc/_services/v0/bodies.py 75.00% 3 Missing ⚠️
src/ansys/geometry/core/designer/body.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2153      +/-   ##
==========================================
+ Coverage   94.58%   94.68%   +0.09%     
==========================================
  Files         141      141              
  Lines       10294    10334      +40     
==========================================
+ Hits         9737     9785      +48     
+ Misses        557      549       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants