FEAT: refactoring and implementation to export C matrix #5768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmalinve
requested review from
maxcapodi78,
Samuelopez-ansys and
SMoraisAnsys
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5768 +/- ##
==========================================
+ Coverage 81.10% 84.77% +3.67%
==========================================
Files 157 157
Lines 61664 61687 +23
==========================================
+ Hits 50010 52296 +2286
+ Misses 11654 9391 -2263 |
2 tasks
gmalinve
changed the title
anur7
approved these changes
Feb 14, 2025
SMoraisAnsys
requested changes
Feb 14, 2025
| SOLUTIONS.Maxwell2d.EddyCurrentZ, | ||
| SOLUTIONS.Maxwell3d.EddyCurrent, | ||
| ]: | ||
| self.logger.error("RL Matrix can only be exported if solution type is Eddy Current.") |
There was a problem hiding this comment.
Could you raise an exception here ?
Comment on lines
+2192
to
+2201
| if not matrix_names_list: | ||
| self.logger.error("Matrix list is empty, can't export a valid matrix.") | ||
| return False | ||
| elif matrix_name not in matrix_names_list: | ||
| self.logger.error("Matrix name doesn't exist, provide and existing matrix name.") | ||
| return False | ||
|
|
||
| if os.path.splitext(output_file)[1] != ".txt": | ||
| self.logger.error("File extension must be .txt") | ||
| return False |
| SOLUTIONS.Maxwell2d.ElectroStaticZ, | ||
| SOLUTIONS.Maxwell3d.ElectroStatic, | ||
| ]: | ||
| AEDTRuntimeError("C Matrix can only be exported if solution type is Electrostatic.") |
There was a problem hiding this comment.
Suggested change
| AEDTRuntimeError("C Matrix can only be exported if solution type is Electrostatic.") | |
| raise AEDTRuntimeError("C Matrix can only be exported if solution type is Electrostatic.") |
Comment on lines
+2281
to
+2290
| if not matrix_names_list: | ||
| self.logger.error("Matrix list is empty, can't export a valid matrix.") | ||
| return False | ||
| elif matrix_name not in matrix_names_list: | ||
| self.logger.error("Matrix name doesn't exist, provide and existing matrix name.") | ||
| return False | ||
|
|
||
| if os.path.splitext(output_file)[1] != ".txt": | ||
| self.logger.error("File extension must be .txt") | ||
| return False |
Comment on lines
+3943
to
+3944
| self.logger.error("Invalid matrix type. It has to be either 'RL' or 'C'.") | ||
| return False |
Comment on lines
+2229
to
+2231
| except Exception: | ||
| self.logger.error("Solutions are empty. Solve before exporting.") | ||
| return False |
There was a problem hiding this comment.
Could you do except Exception as e: and then raise AEDTRuntimeError(...) from e ?
And the same for other places ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist