Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the color of output cell for sphinx-gallery #85

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

Revathyvenugopal162
Copy link
Contributor

This PR will fix the code output cell color of sphinx gallery. in dark mode. Light mode color retained as it is.
out-dark

Note :

The shade/color of texts and the background will change soon as discussed with documentation team once they are ready with the color codes.

@Revathyvenugopal162 Revathyvenugopal162 self-assigned this Jul 25, 2022
@github-actions github-actions bot added the bug Defects or glitches reported by users or developers label Jul 25, 2022
Copy link
Contributor

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question. Other than that, it looks good to me! Thank you for implementing this so fast!

@@ -2,6 +2,7 @@
@import "../basic.css";
@import url('https://fonts.googleapis.com/css2?family=Inconsolata:wght@600&display=swap');
@import "../tabs.css";
@import "../sg_gallery.css";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@import "../sg_gallery.css";
@import "../sg_gallery.css";

From this line, I'm not sure if a file called sg_gallery.css should be in the _static folder or not. I am no expert in CSS or HTML, so it is your call.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes if we are using sphinx_gallery and importing the package, then it will be there in _static folder.

@Revathyvenugopal162 Revathyvenugopal162 merged commit 0471885 into main Jul 26, 2022
@Revathyvenugopal162 Revathyvenugopal162 deleted the fix/code-cell-style branch July 26, 2022 07:36
@MaxJPRey
Copy link
Contributor

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects or glitches reported by users or developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants