Ship a basic 404 page #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
jorgepiloto
commented
Jul 20, 2022
RobPasMue
approved these changes
Jul 20, 2022
Revathyvenugopal162
approved these changes
Jul 20, 2022
jorgepiloto
force-pushed
the
feat/404-page
branch
from
4a46036
to
7f371b7
Compare
jorgepiloto
force-pushed
the
feat/404-page
branch
3 times, most recently
from
fa6496d
to
5bcdea0
Compare
jorgepiloto
commented
Jul 20, 2022
| ===== | ||
| This is unexpected. The page you are requesting does not exist. | ||
|
|
||
| If this page should exist, please contact `{{ theme_contact_mail }} <mailto:{{ theme_contact_mail }}`_. |
There was a problem hiding this comment.
Considering that some projects may not be linked to GitHub (see #38), we agreed on adding a new theme variable named contact_mail which is used in the 404.rst file.
There was a problem hiding this comment.
We will just have to start enforcing its use across the different docs, right?
There was a problem hiding this comment.
Yes, that's right. Since this is a third party extension, we need to configure it manually. Same happens with the numpydoc, for example.
|
Quick question @jorgepiloto - what's missing in this PR? Is it ready to merge? |
Nothing else to be added from my side. This is ready to be merged 👍🏽 |
|
Merging then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #72 by including a basic 404 page.