Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updata pydata-sphinx-theme. #70

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Updata pydata-sphinx-theme. #70

merged 2 commits into from
Jun 9, 2022

Conversation

germa89
Copy link
Contributor

@germa89 germa89 commented Jun 9, 2022

Update pydata-sphinx-theme to latest version. It should solve ansys/pymapdl#1167

I do not have write-access to this repo so I had to fork.

@jorgepiloto
Copy link
Member

CI is failing since link_logo is named now logo, see pydata theme commit. Could you @germa89 update this variable name in the theme.conf file?

@germa89
Copy link
Contributor Author

germa89 commented Jun 9, 2022

@jorgepiloto I did replace link_logo by logo.link.

Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging! Thanks @germa89 🚀

@jorgepiloto jorgepiloto merged commit 56d6405 into ansys:main Jun 9, 2022
@jorgepiloto
Copy link
Member

Need to investigate the PR labeling issues.

@jorgepiloto jorgepiloto mentioned this pull request Jun 9, 2022
@germa89
Copy link
Contributor Author

germa89 commented Jun 9, 2022

@jorgepiloto do you think you can cut a release in the coming days?

@jorgepiloto
Copy link
Member

Yeah, this is definitely needed. Pinging here @Revathyvenugopal162 to perform a patch release.

@germa89 germa89 deleted the patch-1 branch June 10, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants