Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update labels #61

Merged
merged 3 commits into from
Jun 1, 2022
Merged

Update labels #61

merged 3 commits into from
Jun 1, 2022

Conversation

RobPasMue
Copy link
Member

Closes #60

@RobPasMue RobPasMue linked an issue Jun 1, 2022 that may be closed by this pull request
Change PyPi label - pointing to wrong location #60
Closed
2 tasks
@RobPasMue
Copy link
Member Author

I changed these two labels which were basically not pointing where they should.

PyPi label was pointing to Ansys Templates repo
PyAnsys label should be changed to Ansys label --> we will end up moving the repository to the Ansys org I'm guessing

@RobPasMue
Copy link
Member Author

Current looks:

image

Shouldn't we just use a label like this one for the Python label? I find it way too verbose to specify all Python versions from 3.7 to 3.10:

image

If you agree I can change it in this PR

@RobPasMue RobPasMue self-assigned this Jun 1, 2022
jorgepiloto
jorgepiloto approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @RobPasMue!

Revathyvenugopal162
Revathyvenugopal162 approved these changes Jun 1, 2022
View reviewed changes
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobPasMue Thanks for fixing this!

@RobPasMue
Copy link
Member Author

Just changed the Python label as well to simplify the versions naming. Merging once pipelines succeed! Thanks @Revathyvenugopal162 and @jorgepiloto!

@RobPasMue RobPasMue merged commit c659e90 into main Jun 1, 2022
@RobPasMue RobPasMue deleted the bug/wrong-label branch June 1, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgepiloto jorgepiloto jorgepiloto approved these changes

@Revathyvenugopal162 Revathyvenugopal162 Revathyvenugopal162 approved these changes

@akaszynski akaszynski Awaiting requested review from akaszynski

Assignees

@RobPasMue RobPasMue

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change PyPi label - pointing to wrong location
3 participants
@RobPasMue @jorgepiloto @Revathyvenugopal162