Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/generalize to ansys theme #58

Merged
merged 13 commits into from
May 31, 2022
Merged

Conversation

Revathyvenugopal162
Copy link
Contributor

Fix #46 Generalize the theme by Changing the theme name to ansys-sphinx-theme. Included ansys logos

@Revathyvenugopal162 Revathyvenugopal162 added the enhancement General improvements to existing features label May 30, 2022
@github-actions github-actions bot added the maintenance Generic maintenance related label May 30, 2022
doc/Makefile Outdated Show resolved Hide resolved
doc/source/usage.rst Outdated Show resolved Hide resolved
Revathyvenugopal162 and others added 3 commits May 30, 2022 17:57
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
Co-authored-by: Alex Kaszynski <akascap@gmail.com>
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review May 31, 2022 08:08
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left some minor comments. This is almost ready to go. Thanks for addressing this @Revathyvenugopal162 🚀

doc/source/usage.rst Outdated Show resolved Hide resolved
doc/source/usage.rst Outdated Show resolved Hide resolved
src/ansys_sphinx_theme/theme.conf Outdated Show resolved Hide resolved
Co-authored-by: Jorge Martínez <28702884+jorgepiloto@users.noreply.github.com>
README.rst Show resolved Hide resolved
Copy link
Contributor

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akaszynski akaszynski merged commit 3bde2dc into main May 31, 2022
@akaszynski akaszynski deleted the feat/generalize_to_ansys_theme branch May 31, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvements to existing features maintenance Generic maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generalize theme to become ansys-sphinx-theme
3 participants