Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix:edit this context for undefined domain #286

Merged
merged 5 commits into from
Aug 31, 2023
Merged

Fix:edit this context for undefined domain #286

merged 5 commits into from
Aug 31, 2023

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Aug 30, 2023 •
edited
Loading

Add try block, for the code extracts specific information (domain, signode data, etc.) and formats it into an info dictionary.

@github-actions github-actions bot added the bug Defects or glitches reported by users or developers label Aug 30, 2023
@Revathyvenugopal162 Revathyvenugopal162 mentioned this pull request Aug 30, 2023
Closed
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review August 31, 2023 08:28
@Revathyvenugopal162 Revathyvenugopal162 requested a review from a team as a code owner August 31, 2023 08:28
@Revathyvenugopal162 Revathyvenugopal162 self-assigned this Aug 31, 2023
RobPasMue
RobPasMue reviewed Aug 31, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve it - though I'd prefer to narrow down the kinds of Exceptions we accept

@RobPasMue RobPasMue merged commit 572d621 into main Aug 31, 2023
21 checks passed
@RobPasMue RobPasMue deleted the fix/edit-this-context branch August 31, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

@Revathyvenugopal162 Revathyvenugopal162

Labels
bug Defects or glitches reported by users or developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Revathyvenugopal162 @RobPasMue