fix: rename the extension name with no conflict

[Revathyvenugopal162]

fix #274

[germa89]

I don't see how the changes proposed can alleviate #274 ... Can you explain a bit please?

[RobPasMue]

I don't see how the changes proposed can alleviate #274 ... Can you explain a bit please?

Agreed, me neither

[Revathyvenugopal162]

I don't see how the changes proposed can alleviate #274 ... Can you explain a bit please?

i think the function 'fix_edit_link_button' is defined in ansys-sphinx theme and in pymapdl, made the jinja to add the function in html context, and shadowing fix_edit_link_button function, leading to unexpected behavior of looking for an extension named ansys.

[Revathyvenugopal162]

I tried it locally and it is fixing my error for pymapdl!

[RobPasMue]

Oh... so it's because PyMAPDL has it's own function? In that case... we might want to change PyMAPDL rather than the Sphinx theme... right?

[Revathyvenugopal162]

Oh... so it's because PyMAPDL has it's own function? In that case... we might want to change PyMAPDL rather than the Sphinx theme... right?

Yes, but i think we both got that name from pyvista, if we are adding this as another extension or add theme in public themes, it should not conflict another library, so i changed it here.!
But changing for the moment in pymapdl will also solve the issue.

[RobPasMue]

Yes, but i think we both got that name from pyvista, if we are adding this as another extension or add theme in public themes, it should not conflict another library, so i changed it here.! But changing for the moment in pymapdl will also solve the issue.

Okay, let's accept the change then =)

[germa89]

With the recent explanations, I see the point for this PR and I approve it.

Looking forward to see this change in the next release. Thank a lot @Revathyvenugopal162 !! 😄

[germa89]

By the way, I guess your fix for the "edit button" should also work with PyMAPDL I guess? So maybe we can remove that bit from PyMAPDL.

[germa89]

Also, how did you discover what was the reason? It seems to me the error was a bit obscure. Very good job!

[Revathyvenugopal162]

By the way, I guess your fix for the "edit button" should also work with PyMAPDL I guess? So maybe we can remove that bit from PyMAPDL.

i believe, we can remove some code and the extension with these changes.

[MaxJPRey]

Thanks for the explanations @Revathyvenugopal162 .

[germa89]

By the way, I guess your fix for the "edit button" should also work with PyMAPDL I guess? So maybe we can remove that bit from PyMAPDL.

i believe, we can remove some code and the extension with these changes.

I will.. eventually... one day.. find the time for this. 🥲

[RobPasMue]

Can we merge this BTW?

[germa89]

We will need a patch release for this.

[RobPasMue]

Yep, @Revathyvenugopal162 - please plan on it

[Revathyvenugopal162]

Sure, i will do this Morning.