Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add actions for pymeilisearch indexing #271

Merged
merged 6 commits into from
Aug 10, 2023
Merged

Feat: add actions for pymeilisearch indexing #271

merged 6 commits into from
Aug 10, 2023

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Aug 9, 2023 •
edited
Loading

This PR consists of the following updates :

  • Update license file
  • add code owner
  • python version update
  • add Pymeilisearch index actions

@github-actions github-actions bot added documentation maintenance Generic maintenance related enhancement General improvements to existing features labels Aug 9, 2023
@Revathyvenugopal162 Revathyvenugopal162 requested review from jorgepiloto and RobPasMue and removed request for jorgepiloto August 9, 2023 16:54
RobPasMue
RobPasMue approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions but LGTM!

LICENSE Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@Revathyvenugopal162 @RobPasMue
Apply suggestions from code review
f81b6d2 
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
@Revathyvenugopal162 Revathyvenugopal162 enabled auto-merge (squash) August 10, 2023 08:10
@Revathyvenugopal162 Revathyvenugopal162 merged commit 943f10a into main Aug 10, 2023
18 checks passed
@Revathyvenugopal162 Revathyvenugopal162 deleted the feat/add-actions branch August 10, 2023 08:14
Revathyvenugopal162 added a commit that referenced this pull request Aug 10, 2023
@Revathyvenugopal162 @RobPasMue
Feat: add actions for pymeilisearch indexing (#271)
6e98090 
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@jorgepiloto jorgepiloto Awaiting requested review from jorgepiloto

Assignees
No one assigned
Labels
enhancement General improvements to existing features maintenance Generic maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Revathyvenugopal162 @RobPasMue