MAINT: Change the index-uid compactible with search-index #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
bug
jorgepiloto
requested changes
Jul 26, 2023
| str | ||
| pymeilisearch-compatible version number. | ||
| """ | ||
| version = get_version_match(semver).replace(".", "-") |
There was a problem hiding this comment.
Does this mean that a version like "v45.12" will render as "v45-12"? Is this imposed by Meilisearch?
There was a problem hiding this comment.
yes, it is imposed by meilisearch( taking index with - or _ and no other special characters)
There was a problem hiding this comment.
In that case, let's go with the "-" instead of "_".
jorgepiloto
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meilisearch will not accept the index having
.it will only accept the index with-.