Improve appearance and behavior of ReST :download: links
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
germa89
approved these changes
Feb 2, 2022
| /* Add target="_blank" attribute to all hyperlinks generated by the ReST :download: directive. | ||
| * This will ensure the links open in a new tab. */ | ||
|
|
||
| $(document).ready(function () { |
Thanks! Do you want me to hold off until @akaszynski has a chance to review, or shall I merge? |
|
Up to you really, if you are in rush, just merge it. If not, surely @akaszynski might have some useful contributions. |
|
Nothing to add. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a relatively minor PR to improve how links generated with the ReST
:download:directive work:Before / after screenshots: