Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Add Meilisearch in theme. #200

Merged
merged 28 commits into from
Feb 21, 2023
Merged

FEAT: Add Meilisearch in theme. #200

merged 28 commits into from
Feb 21, 2023

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Feb 15, 2023 •
edited
Loading

Add meilisearch for theme options.

@github-actions github-actions bot added documentation enhancement General improvements to existing features labels Feb 15, 2023
@github-actions github-actions bot added the maintenance Generic maintenance related label Feb 15, 2023
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review February 16, 2023 13:29
RobPasMue
RobPasMue approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - some minor comments

.github/workflows/ci_cd.yml Outdated Show resolved Hide resolved
doc/source/user_guide/options.rst Outdated Show resolved Hide resolved
src/ansys_sphinx_theme/theme/ansys_sphinx_theme/theme.conf Show resolved Hide resolved
@Revathyvenugopal162 @RobPasMue
Update doc/source/user_guide/options.rst
0e6c51e 
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
@Revathyvenugopal162
Add the searchbar styling
030180f
@Revathyvenugopal162
Merge branch 'feat/meiliserch' of https://github.com/ansys/ansys-sphi…
e87f78d 
…nx-theme into feat/meiliserch
@Revathyvenugopal162
Copy link
Contributor Author

image
Added some minor changes on the searchbar style.

@akaszynski @RobPasMue
Update .github/workflows/ci_cd.yml
a8f8637 
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
akaszynski
akaszynski approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursory LGTM after reverting the merge on main… however verify that the search box doesn’t overextend. Does on my browser when zoomed in.

@Revathyvenugopal162
Copy link
Contributor Author

Cursory LGTM after reverting the merge on main… however verify that the search box doesn’t overextend. Does on my browser when zoomed in.

Noted and Fixed.

@Revathyvenugopal162 Revathyvenugopal162 merged commit 793e512 into main Feb 21, 2023
@Revathyvenugopal162 Revathyvenugopal162 deleted the feat/meiliserch branch February 21, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@akaszynski akaszynski akaszynski approved these changes

@MaxJPRey MaxJPRey MaxJPRey approved these changes

@jorgepiloto jorgepiloto Awaiting requested review from jorgepiloto

Assignees
No one assigned
Labels
enhancement General improvements to existing features maintenance Generic maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Revathyvenugopal162 @akaszynski @jorgepiloto @RobPasMue @MaxJPRey