Update the templates and sphinx version. #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
maintenance
MaxJPRey
reviewed
Feb 3, 2023
Comment on lines
-29
to
-31
| {% if item.0 != item.upper().0 %} | ||
| {{ name }}.{{ item }} | ||
| {% endif %} |
There was a problem hiding this comment.
@Revathyvenugopal162 Did you check that it fixed the enum issue in some local documentation without any (obvious) side effects?
I think it should be all good.
There was a problem hiding this comment.
That's a good point, @MaxJPRey.
There was a problem hiding this comment.
I checked, and earlier the autosummary will not render the attributes in uppercase, and now it will support both upper and lower case( especially with enum-class members.)
Before
Rendered new docs.
There was a problem hiding this comment.
Also, PyDF-composite is using the same behavior now.
There was a problem hiding this comment.
Perfect. Thanks @Revathyvenugopal162 .
jorgepiloto
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #186