Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve API doc empty-space formatting #14

Merged
merged 1 commit into from
Dec 11, 2021
Merged

Conversation

Andy-Grigg
Copy link
Contributor

Adds some custom styling to improve the grouping and readability of generated API docs. Side by side comparison (current on left, proposed on right):

image

There's less space between 'Parameters' and 'Examples', and more space between 'Examples' and the methods. This helps the examples feel more like they belong to the class itself, as opposed to the method below.

I'm not a CSS expert, but I think the selectors are appropriate and seem to align with how the styling is written in the base sphinx package. These changes have been tested on the example API Documentation in this package, and on the as-yet-unreleased grantami-bomanalytics package.

Copy link
Contributor

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the style changes. Thanks for adding this. Ping me if you need this now of it can wait until the next release (either minor or patch).

@akaszynski akaszynski merged commit 0a94c8c into main Dec 11, 2021
@akaszynski akaszynski deleted the fix/api-doc-empty-space branch December 11, 2021 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants