Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify css for style changes #116

Merged
merged 3 commits into from
Aug 29, 2022
Merged

Modify css for style changes #116

merged 3 commits into from
Aug 29, 2022

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Aug 26, 2022 •
edited
Loading

Fix #117 , #112 , #115 #114 #113

  • Adding left side nav in similar way of right side nav-bar.
  • Add padding for the on on-this-page
  • Add link color to admonitions ( notes and info)
  • Modify the search bar text color
  • Modify the hover color
  • add padding for images from text
  • Modify tab color for dark theme
    left_panel
    tabs
    admonitions
    padding
    image

@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as draft August 26, 2022 11:35
@github-actions github-actions bot added the maintenance Generic maintenance related label Aug 26, 2022
This was linked to issues Aug 26, 2022
Visibility of note, caution... boxes #100
Closed
Search text is too light #112
Closed
Tabs background in dark theme appears as white #115
Closed
Improve spacing and formatting of "On this page" navigation list #48
Closed
Spacing too small after an image #113
Closed
Fonts for nav bar entries #114
Closed
@Revathyvenugopal162 Revathyvenugopal162 removed a link to an issue Aug 26, 2022
Visibility of note, caution... boxes #100
Closed
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review August 26, 2022 13:41
@Revathyvenugopal162 Revathyvenugopal162 self-assigned this Aug 26, 2022
@MaxJPRey
Copy link
Contributor

Thanks @Revathyvenugopal162 for addressing all the issues.

PipKat
PipKat approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Revathy!

jorgepiloto
jorgepiloto approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @Revathyvenugopal162 🚀

RobPasMue
RobPasMue approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @Revathyvenugopal162

@RobPasMue
Copy link
Member

Since all reviewers approved, I am merging this PR. Thank you all for reviewing and @Revathyvenugopal162 for the implementation!

@RobPasMue RobPasMue merged commit fdef66c into main Aug 29, 2022
@RobPasMue RobPasMue deleted the maint/Modify-css-for-style-and-color branch August 29, 2022 05:14
@jorgepiloto jorgepiloto mentioned this pull request Aug 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chadqueen chadqueen chadqueen approved these changes

@jorgepiloto jorgepiloto jorgepiloto approved these changes

@RobPasMue RobPasMue RobPasMue approved these changes

@PipKat PipKat PipKat approved these changes

@MaxJPRey MaxJPRey MaxJPRey approved these changes

Assignees

@Revathyvenugopal162 Revathyvenugopal162

Labels
maintenance Generic maintenance related
Projects
None yet
Milestone
No milestone
6 participants
@Revathyvenugopal162 @MaxJPRey @RobPasMue @chadqueen @jorgepiloto @PipKat