Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd DataFrame rendering on dark theme #281

Closed
2 tasks done
Andy-Grigg opened this issue Aug 25, 2023 · 5 comments · Fixed by #282
Closed
2 tasks done

Odd DataFrame rendering on dark theme #281

Andy-Grigg opened this issue Aug 25, 2023 · 5 comments · Fixed by #282
Labels
bug Defects or glitches reported by users or developers

Comments

@Andy-Grigg
Copy link
Contributor

🔍 Before submitting the issue

  • I have searched among the existing issues
  • I am using a Python virtual environment

🐞 Description of the bug

In the bomanalytics docs we're seeing some odd rendering of dataframes in dark mode:

Example:

image

There are two issues here:

  • The text should be a lighter color, probably the color used for displaying all text on the page
  • There is a weird outer border, which should probably be transparent

📝 Steps to reproduce

See the code in https://bomanalytics.grantami.docs.pyansys.com/version/stable/_sources/examples/3_Advanced_Topics/3-4_Writing_compliance_results_to_a_dataframe.ipynb.txt

💻 Which operating system are you using?

Windows

📀 Which ANSYS version are you using?

2023 R2

🐍 Which Python version are you using?

3.11

📦 Installed packages

accessible-pygments==0.0.4
aiofiles==22.1.0
aiosqlite==0.19.0
alabaster==0.7.13
-e git+https://github.com/pyansys/grantami-bomanalytics@dfe5511f6c3132654e24f2954cd93de2df1eafc9#egg=ansys_grantami_bomanalytics
ansys-grantami-bomanalytics-openapi==1.1.0
ansys-openapi-common==1.2.2
-e git+https://github.com/pyansys/pyansys-sphinx-theme.git@2d30f5f488718a94e232cc14e8a0a6c4ae064047#egg=ansys_sphinx_theme
anyio==3.7.1
apeye==1.4.1
apeye-core==1.1.4
argon2-cffi==23.1.0
argon2-cffi-bindings==21.2.0
arrow==1.2.3
asttokens==2.2.1
attrs==23.1.0
autodocsumm==0.2.11
Babel==2.12.1
backcall==0.2.0
beautifulsoup4==4.12.2
bleach==6.0.0
CacheControl==0.13.1
certifi==2023.7.22
cffi==1.15.1
charset-normalizer==3.2.0
colorama==0.4.6
comm==0.1.4
coverage==7.3.0
cryptography==41.0.3
cssutils==2.7.1
debugpy==1.6.7.post1
decorator==5.1.1
defusedxml==0.7.1
dict2css==0.3.0
docutils==0.18.1
domdf-python-tools==3.6.1
entrypoints==0.4
enum-tools==0.10.0
executing==1.2.0
fastjsonschema==2.18.0
filelock==3.12.2
fqdn==1.5.1
html5lib==1.1
idna==3.4
imagesize==1.4.1
iniconfig==2.0.0
ipykernel==6.25.1
ipython==8.12.2
ipython-genutils==0.2.0
isoduration==20.11.0
jedi==0.19.0
Jinja2==3.1.2
json5==0.9.14
jsonpointer==2.4
jsonschema==4.19.0
jsonschema-specifications==2023.7.1
jupyter-events==0.7.0
jupyter-ydoc==0.2.5
jupyter_client==7.4.9
jupyter_core==5.3.1
jupyter_server==2.7.2
jupyter_server_fileid==0.9.0
jupyter_server_terminals==0.4.4
jupyter_server_ydoc==0.8.0
jupyterlab==3.6.5
jupyterlab-pygments==0.2.2
jupyterlab_server==2.24.0
jupytext==1.15.0
lxml==4.9.3
markdown-it-py==3.0.0
MarkupSafe==2.1.3
matplotlib-inline==0.1.6
mdit-py-plugins==0.4.0
mdurl==0.1.2
mistune==3.0.1
msgpack==1.0.5
natsort==8.4.0
nbclassic==1.0.0
nbclient==0.8.0
nbconvert==7.7.4
nbformat==5.9.2
nbsphinx==0.9.2
nest-asyncio==1.5.7
notebook==6.5.5
notebook_shim==0.2.3
numpy==1.25.2
numpydoc==1.5.0
overrides==7.4.0
packaging==23.1
pandas==2.0.3
pandocfilters==1.5.0
parso==0.8.3
pickleshare==0.7.5
platformdirs==3.10.0
pluggy==1.2.0
prometheus-client==0.17.1
prompt-toolkit==3.0.39
psutil==5.9.5
pure-eval==0.2.2
pycparser==2.21
pydata-sphinx-theme==0.13.3
Pygments==2.16.1
pyparsing==3.1.1
pypiwin32==223
pyspnego==0.9.1
pytest==7.4.0
pytest-cov==4.1.0
python-dateutil==2.8.2
python-json-logger==2.0.7
pytz==2023.3
pywin32==306
pywinpty==2.0.11
PyYAML==6.0.1
pyzmq==24.0.1
referencing==0.30.2
requests==2.31.0
requests-mock==1.11.0
requests-negotiate-sspi==0.5.2
requests-ntlm==1.2.0
rfc3339-validator==0.1.4
rfc3986-validator==0.1.1
rpds-py==0.9.2
ruamel.yaml==0.17.32
ruamel.yaml.clib==0.2.7
Send2Trash==1.8.2
six==1.16.0
sniffio==1.3.0
snowballstemmer==2.2.0
soupsieve==2.4.1
Sphinx==7.1.2
sphinx-autodoc-typehints==1.24.0
sphinx-copybutton==0.5.2
sphinx-jinja2-compat==0.2.0
sphinx-notfound-page==0.8.3
sphinx-prompt==1.5.0
sphinx-tabs==3.4.1
sphinx-toolbox==3.5.0
sphinxcontrib-applehelp==1.0.4
sphinxcontrib-devhelp==1.0.2
sphinxcontrib-htmlhelp==2.0.1
sphinxcontrib-jsmath==1.0.1
sphinxcontrib-qthelp==1.0.3
sphinxcontrib-serializinghtml==1.1.5
stack-data==0.6.2
tabulate==0.9.0
terminado==0.17.1
tinycss2==1.2.1
toml==0.10.2
tornado==6.3.3
traitlets==5.9.0
typing_extensions==4.7.1
tzdata==2023.3
uri-template==1.3.0
urllib3==2.0.4
wcwidth==0.2.6
webcolors==1.13
webencodings==0.5.1
websocket-client==1.6.2
y-py==0.6.0
ypy-websocket==0.8.4
@Andy-Grigg Andy-Grigg added the bug Defects or glitches reported by users or developers label Aug 25, 2023
@Andy-Grigg
Copy link
Contributor Author

I've already had a bash at fixing some of the css, I'll create a PR with some possible fixes.

@Andy-Grigg
Copy link
Contributor Author

It appears I don't have permission to push to this repository. @MaxJPRey can I be given access? If not, I can share the css modifications some other way.

@RobPasMue
Copy link
Member

Just given you write access @Andy-Grigg - please verify

@MaxJPRey
Copy link
Contributor

Thanks @RobPasMue for granting @Andy-Grigg with the access.

@Andy-Grigg
Copy link
Contributor Author

Thanks @RobPasMue, I can confirm I was able to push my branch.

Andy-Grigg added a commit that referenced this issue Aug 28, 2023
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects or glitches reported by users or developers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants