Skip to content

Commit

Permalink
Simplify message block logic
Browse files Browse the repository at this point in the history
Don't need a switch statement for these cases
  • Loading branch information
cmbuckley authored Oct 2, 2024
1 parent 55e720a commit 2bc8286
Showing 1 changed file with 6 additions and 14 deletions.
20 changes: 6 additions & 14 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,12 @@ function buildMessage(event) {
messageBlock.accessory.alt_text = `${user.login} on GitHub`;
messageBlock.text.text = `*<${user.html_url}|${user.login}>* `;

switch (event.action) {
case 'member_added':
case 'added':
messageBlock.text.text += 'was added to ' + type;
break;

case 'member_removed':
case 'removed':
if (user.login == event.sender.login) {
messageBlock.text.text += 'removed themselves from ' + type;
} else {
messageBlock.text.text += 'was removed from ' + type;
}
break;
if (event.action.includes('added')) {
messageBlock.text.text += 'was added to ' + type;
} else if (user.login == event.sender.login) {
messageBlock.text.text += 'removed themselves from ' + type;
} else {
messageBlock.text.text += 'was removed from ' + type;
}

if (user.login != event.sender.login) {
Expand Down

0 comments on commit 2bc8286

Please sign in to comment.