Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Usage with named-pipes #66

Closed
ansibleguy opened this issue Sep 22, 2024 · 5 comments
Closed

Feature: Usage with named-pipes #66

ansibleguy opened this issue Sep 22, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request security Security

Comments

@ansibleguy
Copy link
Owner

Scope

Service (Job Scheduling, Job Preparation)

Description

As described in the Ansible-Runner docs - we could gain some security when using named pipes instead of basic files:
https://ansible.readthedocs.io/projects/runner/en/latest/intro/#the-env-directory

@ansibleguy ansibleguy added enhancement New feature or request triage Triage labels Sep 22, 2024
@ansibleguy ansibleguy self-assigned this Sep 22, 2024
@ansibleguy ansibleguy added security Security and removed triage Triage labels Sep 22, 2024
@ansibleguy
Copy link
Owner Author

Was not able to get it working by simply replacing basic files with named pipes, as ansible-playbook got stuck.
Now I've removed our custom secrets handling and moved to relying on the one implemented by the official ansible-runner, as this make way more sense.

@ansibleguy
Copy link
Owner Author

Was able to provision my hosts with become+ssh-key+vault-pass.
@mathieumd Would be nice if you could test it too - just to be sure.

@ansibleguy
Copy link
Owner Author

Note: Git-repository handling is still using a basic file. Will need to implement ssh-agent usage for that use-case

@mathieumd
Copy link

Looks good with SSH through ssh-agent:

Running command:
ansible-playbook --diff -i inventory/all --limit test01 playbooks/test.yml

Identity added: /var/tmp/ansible-webui/2024-09-23_10-58-2154984/artifacts/74174416-b4ad-4965-80fd-7b7575ab5853/ssh_key_data (ansibleguy-webui@example01)

This file ssh_key_data is removed very quickly, just after the ssh-add, nice. Is it the named pipe?

It still requires an unencrypted SSH private key, which makes me unconfortable; but maybe it's actually enough security-wise? I can't tell. :-)

@ansibleguy
Copy link
Owner Author

Will add a feature-request for encrypted ssh keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request security Security
Projects
None yet
Development

No branches or pull requests

2 participants