Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing ansible-compat runtime dependency #246

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Added missing ansible-compat runtime dependency #246

merged 1 commit into from
Jan 10, 2024

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Jan 10, 2024 •
edited
Loading

  • adds missing ansible-compat runtime dependency
  • adds a fail-safe test in pkg environment to detect a similar bug (missing runtime deps)
  • updated testing dependencies
  • reorganized requirements files to make their purpose clear

@ssbarnea ssbarnea requested a review from a team as a code owner January 10, 2024 12:49
@ssbarnea ssbarnea requested review from Qalthos and priyamsahoo and removed request for a team January 10, 2024 12:49
@ssbarnea ssbarnea added the bug label Jan 10, 2024
@cristianonicolai cristianonicolai merged commit 62b5f72 into main Jan 10, 2024
15 checks passed
@cristianonicolai cristianonicolai deleted the fix/deps-compat branch January 10, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shatakshiiii shatakshiiii shatakshiiii approved these changes

@Qalthos Qalthos Qalthos approved these changes

@cristianonicolai cristianonicolai cristianonicolai approved these changes

@priyamsahoo priyamsahoo Awaiting requested review from priyamsahoo priyamsahoo is a code owner automatically assigned from ansible/devtools

Assignees
No one assigned
Labels
bug
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ssbarnea @cristianonicolai @Qalthos @shatakshiiii